Skip to content

8358627: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26 #25855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Jun 17, 2025

Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved, JavaBaseCheckSince no longer needs to be problemlisted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Patch contains a binary file (test/jdk/jdk/internal/loader/URLClassPath/testclasses.jar)

Issue

  • JDK-8358627: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25855/head:pull/25855
$ git checkout pull/25855

Update a local copy of the PR:
$ git checkout pull/25855
$ git pull https://git.openjdk.org/jdk.git pull/25855/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25855

View PR using the GUI difftool:
$ git pr show -t 25855

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25855.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@nizarbenalla nizarbenalla changed the base branch from master to pr/25854 June 17, 2025 15:33
@nizarbenalla
Copy link
Member Author

/label add javadoc
/label add core-libs

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@nizarbenalla
The javadoc label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@nizarbenalla
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/25854 to master June 19, 2025 10:43
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout problemlisted-sincecheck-test
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@nizarbenalla
Copy link
Member Author

nizarbenalla commented Jun 23, 2025

Now that #25854 has been integrated, the test no longer need to be problemlisted.

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@nizarbenalla this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout problemlisted-sincecheck-test
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] javadoc [email protected] merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants